filesystem.py: prevent recursively traversing the root filesystem #576
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent recursively traversing the root filesystem
climbfuji
force-pushed
the
bugfix/dont_traverse_root
branch
from
3b15509 to
47fce0d
Compare
10 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
mathomp4 and
rickgrubin-noaa
10 tasks
rickgrubin-noaa
approved these changes
Feb 11, 2026
github-project-automation
bot
moved this from In Progress
to Done
in spack-stack-2.1.x (2026 Q1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix/workaround in
lib/spack/spack/llnl/util/filesystem.py: prevent recursively traversing the root filesystem.This is necessary for Derecho, see discussion in spack#51311.
This may not be the final answer, but it is good and safe enough for us to move forward.
Testing